Skip to content

Update version of build machinery to fix make verify PROW job#619

Closed
florkbr wants to merge 1 commit intoopenshift:masterfrom
florkbr:fix-buildmachinery-errors
Closed

Update version of build machinery to fix make verify PROW job#619
florkbr wants to merge 1 commit intoopenshift:masterfrom
florkbr:fix-buildmachinery-errors

Conversation

@florkbr
Copy link
Copy Markdown
Contributor

@florkbr florkbr commented Dec 14, 2021 •
edited
Loading

This will need to be ported to our master-multi-cluster branch

See: openshift/build-machinery-go#58

CC @TheRealJon @spadgett @jhadvig

@florkbr
Update version of build machinery to fix make verify PROW job
945319e 
This will need to be ported to our master-multi-cluster branch

See: openshift/build-machinery-go#58

CC @TheRealJon @spadgett
@florkbr florkbr requested a review from TheRealJon December 14, 2021 16:48
@florkbr
Copy link
Copy Markdown
Contributor Author

florkbr commented Dec 14, 2021

If you look at the console-operator open PRs, you'll see all are failing against master and master-multi-cluster-feature for the verify job. This is an upstream build issue that has been fixed (mirror for dependency disappeared). Bumping the version of build machinery fixes the issue.

@florkbr
Copy link
Copy Markdown
Contributor Author

florkbr commented Dec 14, 2021

https://search.ci.openshift.org/?search=Error+22&maxAge=48h&context=1&type=bug%2Bjunit&name=console-operator&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job

image

TheRealJon
TheRealJon approved these changes Dec 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2021
@florkbr
Copy link
Copy Markdown
Contributor Author

florkbr commented Dec 14, 2021

/retest

@florkbr florkbr mentioned this pull request Dec 14, 2021
Closed
@florkbr
Copy link
Copy Markdown
Contributor Author

florkbr commented Dec 15, 2021

/retest

@yselkowitz
Copy link
Copy Markdown
Contributor

yselkowitz commented Dec 16, 2021

This is blocking all other PRs.
/assign @spadgett
/retest

@yselkowitz yselkowitz mentioned this pull request Dec 16, 2021
Merged
@florkbr
Copy link
Copy Markdown
Contributor Author

florkbr commented Dec 16, 2021

/retest

@florkbr
Copy link
Copy Markdown
Contributor Author

florkbr commented Dec 16, 2021

dial tcp 10.0.229.112:10250: connect: connection refused]]]error: gather did not start for pod must-gather-tf874: timed out waiting for the condition

Network issues. Retesting.

@florkbr
Copy link
Copy Markdown
Contributor Author

florkbr commented Dec 16, 2021

/retest

@florkbr
Copy link
Copy Markdown
Contributor Author

florkbr commented Dec 16, 2021

Different failure in metrics endpoint related to network conditions: [Get "https://10.0.176.233:10250/containerLogs/openshift-cluster-csi-drivers/aws-ebs-csi-driver-node-gxxp8/csi-driver?previous=true×tamps=true": dial tcp 10.0.176.233:10250: connect: connection refused

Retesting

@florkbr
Copy link
Copy Markdown
Contributor Author

florkbr commented Dec 16, 2021

/retest

1 similar comment
@florkbr
Copy link
Copy Markdown
Contributor Author

florkbr commented Dec 17, 2021

/retest

spadgett
spadgett approved these changes Dec 17, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: florkbr, spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 17, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 17, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 17, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 18, 2021

@florkbr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 23, 2021

@florkbr: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2021
@florkbr
Copy link
Copy Markdown
Contributor Author

florkbr commented Jan 4, 2022

This was merged into master by #615. Closing for now.

@florkbr florkbr closed this Jan 4, 2022
@florkbr florkbr mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@TheRealJon TheRealJon TheRealJon approved these changes

Assignees

@spadgett spadgett

@TheRealJon TheRealJon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@florkbr @yselkowitz @openshift-bot @spadgett @TheRealJon